This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid removing content size constraints #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, on iOS 8.0+, use `+[NSLayoutConstraint activateConstraints:]` and `+deactivateConstraints:` to efficiently prevent redundant constraints from lingering. Fixes #1779.
1ec5
force-pushed
the
1ec5-constraints-tab-view-1779
branch
from
378b7cd to
5ea41a5
Compare
|
EXC_BAD_ACCESS [NSLayoutConstraint deactivateConstraints:self.logoViewConstraints]; all the time if you are using singleton for the map view |
|
@robipresotto, please open a new issue regarding this crash. If possible, please provide more information about the environment, for example the verisons of iOS and Mapbox GL, device model, and whether you’re creating the map view programmatically or with a storyboard. Thanks! |
|
Also, please set an Objective-C exception breakpoint and provide the stack trace at the point of the exception being thrown. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids removing content size constraints that are needed to maintain the intrinsic size of the logo and ℹ️. Also, on iOS 8.0+, we now use
+[NSLayoutConstraint activateConstraints:]and+deactivateConstraints:to efficiently prevent redundant constraints from lingering.Fixes #1779.
/cc @friedbunny @incanus