This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fit to coordinates #1795
Merged
Fit to coordinates #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-district=crazytown
branch
from
45a7423 to
25d61d1
Compare
Whoever determined the boundaries of the District of Columbia did not have fit-to-bounds implementations in mind. With this change, shapes that are not unrotated rectangles fit much, much better.
1ec5
force-pushed
the
1ec5-district=crazytown
branch
from
25d61d1 to
ac2ad99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoever determined the boundaries of the District of Columbia did not have #1783 in mind. This PR generalizes the fit to bounds functionality added in #1783 so that shapes other than unrotated rectangles still fit well when the map view is rotated. Here’s iosapp without this PR, fitted to the District with just enough padding for the top bar:
and with this PR:
Here’s a decidedly non-rectangular trace (Add Test Shapes in the gear menu) without this PR:
and with:
This functionality belongs in mbgl::Map, as opposed to client code, because much larger shapes may be distorted by the projection; apps linked against Mapbox GL don’t have enough information to reliably account for that distortion.
/cc @incanus @friedbunny @kelvinabrokwa