This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Clean up transition durations & time points #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
from
ffbb01d
to
9ced348
Compare
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
from
9ced348
to
b7c2a21
Compare
| void setDefaultTransitionDuration(Duration = Duration::zero()); | ||
| Duration getDefaultTransitionDuration(); | ||
| void setDefaultTransitionDuration(const Duration& = Duration::zero()); | ||
| const Duration getDefaultTransitionDuration() const; |
There was a problem hiding this comment.
returning a const integral type isn't meaningful.
There was a problem hiding this comment.
Good point, I guess that went through on my regular expression 👻 will remove that.
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
from
b7c2a21
to
28c6d44
Compare
|
👍 |
- Let style classes cascade use the same time point as the one used to recalculate style. - Cleaned up MapContext::update to return early whenever possible. - Cleaned up MapContext::loadStyleJSON to avoid redundant calls to style classes cascade.
This list stores different values for the same property, but the property itself remains the same.
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
2 times, most recently
from
2327d46
to
a34e6cd
Compare
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
2 times, most recently
from
2bda4f0
to
9ad8c41
Compare
Relevant changes: - Added 'defaultFadeDuration' and 'defaultTransitionDelay' to MapData; - Painter & StyleParser now receives a reference to MapData; - As previously seen on the code: 300ms is the default fade duration and 0ms is the default transition duration; - We no longer pass the current time point to Style, since it now uses MapData.animationTime, which gets updated in MapContext::update(). - Updated StyleParser check to use a mock MapData;
brunoabinader
force-pushed
the
transition-unify-refactoring
branch
from
9ad8c41
to
0ea8a37
Compare
AndwareSsj
pushed a commit
to AndwareSsj/mapbox-gl-native
that referenced
this pull request
Nov 6, 2015
Added a setter/getter for default transition delay, in the same fashion as the default transition duration. Spin-off from mapbox#1888. Fixes mapbox#302.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes:
MapData:defaultFadeDurationanddefaultTransitionDelaytoMapData;Painter&StyleParsernow receives a reference toMapData;Style, since it now usesMapData.animationTime, which gets updated inMapContext::update().StyleParsercheck to use a mockMapData;Duration,TimePoint} by const ref whenever possible;recalculate style.
MapContext::update()to return early whenever possible.MapContext::loadStyleJSON()to avoid redundant calls to styleclasses cascade.
Part of #1548.
/cc @jfirebaugh @kkaefer @tmpsantos @tmcw