This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Map view gets black screen after changing style if default transition duration != 0 #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bisect gave me this one 7023ea0 |
|
👍 |
jfirebaugh
added a commit
that referenced
this pull request
May 2, 2017
This should happen automatically during rendering. After removing, I can no longer replicate the original issue (#1889).
jfirebaugh
added a commit
that referenced
this pull request
May 3, 2017
This should happen automatically during rendering. After removing, I can no longer replicate the original issue (#1889).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this while debugging for #1548. If the client manually sets a default transition duration (example), after changing a style the screen goes black (with only symbols appearing) until you trigger another view update (like zooming in and out of screen).
Steps to reproduce:
Rkey (which triggers a client-side update on the default transition duration)Skey
/cc @jfirebaugh @tmcw @kkaefer @tmpsantos