This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move mapbox/mapbox-gl-styles to mb-pages branch #1910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ios-b1 branch of mapbox/mapbox-gl-styles is getting further and further behind mb-pages, as one would expect. The main reason we’re using a branch is so that we don’t end up bundling old versions of styles with Mapbox GL. This PR moves the submodule pin to mb-pages and causes the package script to filter to just the desired styles. It assumes that we’ll be on the lookout for any post-0.3.0 regressions in the stylesheets that have never shipped with Mapbox GL before.
(An alternative fix would be to restructure the mapbox/mapbox-gl-styles repository so that each -v* would be its own branch. That is, a v7 branch would contain mapbox-streets.json, emerald.json, etc. Then Mapbox GL could pull in just the v7 branch’s JSON files.)
/cc @incanus @bleege @nickidlugash @peterqliu @andreasviglakis @samanpwbb