Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Avoid nudging transitions if a gesture is in progress #2 #1928

Closed
wants to merge 0 commits into from

Conversation

brunoabinader
Copy link
Member

Following the same steps from #1548 and #1912 for GLFW and iOS ports.
Also removed a redundant check if transform state is changing since
we're already dealing with that.

/cc @incanus @kkaefer @tmpsantos

@brunoabinader brunoabinader added performance Speed, stability, CPU usage, memory usage, or power usage iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Linux labels Jul 24, 2015
brunoabinader added a commit that referenced this pull request Jul 24, 2015
@incanus
Copy link
Contributor

incanus commented Jul 24, 2015

This seems to break iOS animated transitions.

To reproduce:

  1. Start with map.
  2. Two-finger tap to (animated) zoom out.
  3. Map doesn't move.

Others: double-tap to zoom in, pan "toss" to coast stops immediately, etc.

@brunoabinader
Copy link
Member Author

This seems to break iOS animated transitions.

Got it 👍 it seems self.isAnimatingGesture is not exactly what we want to check there.

@brunoabinader brunoabinader force-pushed the avoid-nudge-transitions-if-gesturing branch from 9290249 to e20200b Compare July 27, 2015 09:06
@brunoabinader brunoabinader force-pushed the avoid-nudge-transitions-if-gesturing branch from e20200b to 5e2f3b1 Compare July 27, 2015 18:58
@brunoabinader brunoabinader deleted the avoid-nudge-transitions-if-gesturing branch July 27, 2015 18:58
@incanus
Copy link
Contributor

incanus commented Jul 27, 2015

I know you merged already, but this is looking great in my testing @brunoabinader 👍.

brunoabinader added a commit that referenced this pull request Jul 31, 2015
brunoabinader added a commit that referenced this pull request Aug 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants