This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid nudging transitions if a gesture is in progress #2 #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
added
performance
|
This seems to break iOS animated transitions. To reproduce:
Others: double-tap to zoom in, pan "toss" to coast stops immediately, etc. |
Got it 👍 it seems |
brunoabinader
force-pushed
the
avoid-nudge-transitions-if-gesturing
branch
from
9290249
to
e20200b
Compare
brunoabinader
force-pushed
the
avoid-nudge-transitions-if-gesturing
branch
from
e20200b
to
5e2f3b1
Compare
|
I know you merged already, but this is looking great in my testing @brunoabinader 👍. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same steps from #1548 and #1912 for GLFW and iOS ports.
Also removed a redundant check if transform state is changing since
we're already dealing with that.
/cc @incanus @kkaefer @tmpsantos