User location puck for course tracking mode #2233

friedbunny · 2015-09-02T03:51:03Z

Adds a "puck" that replaces the user location dot when MGLUserLocationTrackingModeCourse is active.

Moves the current dot drawing code to -drawDot
Adds -drawPuck
Adds _puckModeActivated boolean
- Used to reset the layers when switching between dot/puck
Draws a bezier arrow graphic for the puck in -puckArrow

There are still a variety of things to do:

Pitch the puck with CATransform3D
Code cleanup
Tweak visual style (shadow?)
Test with rotated/pitched camera
Add option to use the puck without MGLUserLocationTrackingModeCourse?
Update MGLMapView where necessary
Add transitions when switching between dot and puck

Fixes #2188.

/cc @incanus @1ec5 @mapbox/mobile

1ec5 · 2015-09-04T01:41:02Z

platform/ios/MGLUserLocationAnnotationView.m

+    }
+}
+
+CGFloat MGLRadiansFromDegrees(CLLocationDegrees degrees)


These methods are also defined in MGLMapView.mm. Can you factor these implementations out into MGLGeometry.h?

Yup, I'll do that.

friedbunny · 2015-09-04T03:52:24Z

Tilting the map now also tilts the puck:

Also: rebased on master and toned down the shadow (a bit too much, as it turns out).

We explicitly don't tilt the user dot right now, but it actually looks pretty good, too:

friedbunny · 2015-09-04T05:47:36Z

I added pitch to the user dot.

Why?

The accuracy ring looks terrible unpitched on a tilted map
It was really simple to implement
It's cool and looks better, even if it diverges from Apple Maps

The pitched accuracy ring still has sizing issues: vertical screen movement isn't accounted for and all elements of the annotation (and puck) keep a constant scale, even though they shouldn't.

1ec5 · 2015-09-04T14:10:52Z

I agree with tilting the accuracy ring, but tilting the dot itself looks odd unless we give it some thickness or elevation.

friedbunny · 2015-09-04T17:49:12Z

incanus · 2015-09-04T17:51:33Z

http://a.loudgif.com/1ilWRZ0

1ec5 · 2015-09-04T20:59:40Z

As of 17003db:

The user dot is now drawn twice: each instance of the dot is masked to show a semicircle, and only the lower semicircle is tilted, giving the illusion of a hemispherical bubble.

Back to @friedbunny for review.

friedbunny · 2015-09-05T03:32:07Z

My current thinking is that:

Setting the transform property on many individual CALayers is too slow and introduces noticeable lag when you're using the tilt gesture.
Go back to setting the parent CALayer.subLayerTransform and then retransform the dome layer to flat.
... but this adds flickering in the dot layer and the dome layer during the tilting gesture.
So only allow the (animated) dome transform to happen after the tilting is over. WIP.

Previously in #2265 we would ask for location permission at app startup if `!settings->showsUserLocation`. #2193 0a172a2 changed the way we used `NSUserDefaults` and mostly removed the `settings` object, which broke #2265. Rather than fix our pestering location permissions ask at startup, this commit now only asks for location permissions when the user hits the locate-me button. Once a user grants permission, the user dot appears because a `userTrackingMode` is set, `showsUserLocation` is permanently set to `YES` in `NSUserDefaults` and is restored at launch.

I'm not much of a hockey fan, but those playoff beards are pretty swell.

This exposes the naïveté of the current pitch transform: accuracy ring sizing stays constant, despite vertical screen movement. Still, it looks better pitched than not.

friedbunny · 2015-09-09T02:47:08Z

Still fighting flickering during the tilt gesture, tracked it down to the animations. Now animations are paused and unpaused when the gesture starts/finishes.

Sadly, I'm considering ditching the 3D flying-saucer look and seeing if not pitching the dot (only the accuracy ring) is a viable option.

friedbunny · 2015-09-09T02:57:08Z

The masking appears to be an issue here, too. If we were to only transform the inner dot (and not split it in two, then mask one side) that might improve the flickering.

1ec5 · 2015-09-09T03:17:20Z

Instead of masking, maybe we could draw both halves of the dot as actual semicircles.

I couldn't get the dome to perform well and not flicker, so pour one out for the cool flying saucer that could have been.

friedbunny · 2015-09-10T18:02:31Z

I think we're ready to go here. Next step is to rebase, squash, and get some eyes on this.

Ended up removing the dome and going with another faux 3D-ism by setting the zPosition for the inner dot to raise as the map is tilted. This skips the flickering and/or lag that I failed to eliminate from the dome implementation.

1ec5 · 2015-09-10T18:04:31Z

If we ever allow pitching beyond 60°, we’ll have to revisit this approach and probably figure out how to make the dome work, but this looks great as-is.

friedbunny · 2015-09-10T18:10:55Z

friedbunny · 2015-09-10T20:17:30Z

Squashed over in #2300. Thanks for the memories, #2233.

friedbunny added feature iOS Mapbox Maps SDK for iOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Sep 2, 2015

mourner added the in progress label Sep 2, 2015

friedbunny force-pushed the skate-to-where-the-puck-will-be branch from e6e8ed6 to 2205b2d Compare September 4, 2015 01:36

1ec5 reviewed Sep 4, 2015
View reviewed changes

friedbunny force-pushed the skate-to-where-the-puck-will-be branch from baf647b to 2eba2ce Compare September 4, 2015 05:46

1ec5 assigned 1ec5 and friedbunny and unassigned 1ec5 Sep 4, 2015

1ec5 added ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold and removed ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Sep 4, 2015

friedbunny and others added 11 commits September 8, 2015 11:43

Merge branch '2283-custom-infowindow-handling'

a6ef907

Initial user location puck

816c64a

I'm not much of a hockey fan, but those playoff beards are pretty swell.

frameSize doesn't need to be global

d795116

Tone down puck shadow size & opacity

c8199a2

Remove dead code

c4e362e

Pitch that puck, but don't pitch the dot

391efb4

Move radians/degrees conversion functions to MGLGeometry.h

060c979

Boost puck size, tweak shadow

035a36f

Only update transform if pitch has changed

5f878b9

Pitch the dot

1a484c0

This exposes the naïveté of the current pitch transform: accuracy ring sizing stays constant, despite vertical screen movement. Still, it looks better pitched than not.

friedbunny and others added 8 commits September 8, 2015 16:55

Add faux 3D effect to tilted dot and puck

6e5c253

Don't re-set shadow properties

b4ce99c

Expose a user bubble when tilted

c456ef2

Also tilt the puck

11a39e4

Tilt the puck for real

50ff697

Fix perf, but add nubbin flicker

d55c242

Reduce flickering somewhat, make code suuuuuper ugly

fcfc96b

Rebase; pause/unpause animations during tilt gesture

db4a836

friedbunny force-pushed the skate-to-where-the-puck-will-be branch from f244254 to db4a836 Compare September 9, 2015 02:44

brunoabinader force-pushed the master branch from 532bbd5 to 8f37502 Compare September 10, 2015 16:21

Abandon the dome, use simple z offset to fake depth when tilted

b0b826f

I couldn't get the dome to perform well and not flicker, so pour one out for the cool flying saucer that could have been.

friedbunny mentioned this pull request Sep 10, 2015

User location puck for course tracking mode [squash] #2300

Merged

friedbunny closed this Sep 10, 2015

mourner removed the in progress label Sep 10, 2015

friedbunny deleted the skate-to-where-the-puck-will-be branch September 10, 2015 20:17

1ec5 mentioned this pull request Oct 5, 2015

Add puck for course tracking mode #2188

Closed

1ec5 removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Nov 9, 2015

1ec5 mentioned this pull request Dec 4, 2015

Tilt user dot on Android #3189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User location puck for course tracking mode #2233

User location puck for course tracking mode #2233

friedbunny commented Sep 2, 2015

1ec5 Sep 4, 2015

friedbunny Sep 4, 2015

friedbunny commented Sep 4, 2015

friedbunny commented Sep 4, 2015

1ec5 commented Sep 4, 2015

friedbunny commented Sep 4, 2015

incanus commented Sep 4, 2015

1ec5 commented Sep 4, 2015

friedbunny commented Sep 5, 2015

friedbunny commented Sep 9, 2015

friedbunny commented Sep 9, 2015

1ec5 commented Sep 9, 2015

friedbunny commented Sep 10, 2015

1ec5 commented Sep 10, 2015

friedbunny commented Sep 10, 2015

friedbunny commented Sep 10, 2015

User location puck for course tracking mode #2233

User location puck for course tracking mode #2233

Conversation

friedbunny commented Sep 2, 2015

1ec5 Sep 4, 2015

Choose a reason for hiding this comment

friedbunny Sep 4, 2015

Choose a reason for hiding this comment

friedbunny commented Sep 4, 2015

friedbunny commented Sep 4, 2015

I added pitch to the user dot.

1ec5 commented Sep 4, 2015

friedbunny commented Sep 4, 2015

incanus commented Sep 4, 2015

1ec5 commented Sep 4, 2015

friedbunny commented Sep 5, 2015

friedbunny commented Sep 9, 2015

friedbunny commented Sep 9, 2015

1ec5 commented Sep 9, 2015

friedbunny commented Sep 10, 2015

1ec5 commented Sep 10, 2015

friedbunny commented Sep 10, 2015

friedbunny commented Sep 10, 2015