This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Return raw image buffer instead of an object #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.ok(data.pixels); | ||
| t.equal(data.width, 512); | ||
| t.equal(data.height, 512); | ||
| t.ok(pixels); |
There was a problem hiding this comment.
Can you add a t.ok(pixels instanceof Buffer) assertion here? I've been meaning to add that.
There was a problem hiding this comment.
Also t.equal(pixels.length, 512 * 512 * 4).
bsudekum
pushed a commit
that referenced
this pull request
Sep 4, 2015
Return raw image buffer instead of an object
AndwareSsj
pushed a commit
to AndwareSsj/mapbox-gl-native
that referenced
this pull request
Nov 6, 2015
Return raw image buffer instead of an object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #2258
Currently we're returning an object from the
map.renderfunction:{ "height": 60, "width": 60, "pixels": "<SlowBuffer 34 43 45 ...>" }This is overkill since the height and width are already know because they are necessary to render an image in the first place. Although this is a small change, the system needs to allocate memory to do these processes which can add up. This change would no longer return an object but rather just the raw image buffer.
/cc @mikemorris @springmeyer @jfirebaugh