This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Add satellite streets style #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We purposely excluded Bright, Basic, and Empty from the iOS SDK. |
|
@1ec5 Why is that? |
|
In short, while these styles are useful as Mapbox Studio templates, they aren't what we would consider ready-made styles – particularly not Empty. 😉 |
|
@1ec5 True. OK I'll just add satellite streets. |
ljbade
force-pushed
the
2739-all-styles
branch
from
7c40a74
to
c0ada83
Compare
|
PR updated, waiting for Travis then merge. |
ljbade
force-pushed
the
2739-all-styles
branch
4 times, most recently
from
f1bdc84
to
a7e3029
Compare
ljbade
changed the title
ljbade
force-pushed
the
2739-all-styles
branch
from
a7e3029
to
f71d61f
Compare
|
@ljbade, I think the new style should be called just Hybrid on iOS. "Satellite-Hybrid" is a bit unwieldy. |
|
Or "Satellite Streets", per #2740 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739
Fixes #2740