This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update after final frame of transition #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-update-post-transition-2946
branch
2 times, most recently
from
64ed536 to
5a389e1
Compare
The final frame is self-destructing – it destroys the frame and finish functions – so technically we’re no longer inTransition(). Yet there still needs to be an update after that final frame. Also, avoid a redundant change notification on the last frame. (It would come too late, after the DidChange notification, anyhow.) Fixes #2946.
1ec5
force-pushed
the
1ec5-update-post-transition-2946
branch
from
5a389e1 to
1745141
Compare
|
Travis and Bitrise both pass; merging without waiting another time. |
|
Nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final frame is self-destructing – it destroys the frame and finish functions – so technically we’re no longer
inTransition(). Yet there still needs to be an update after that final frame.Also, this PR removes a redundant IsChanging notification that was being sent from the final frame of the transition. It would’ve come after the finish function’s DidChange notification.
Fixes #2946.
/cc @brunoabinader