This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #2966: remove -ObjC linker flag & bring in categories via other means #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| void linkBundleCategory(); | |||
There was a problem hiding this comment.
These functions should not be public. Will this still work if you declare them in MGLCategoryLoader.m (but still implement them where they are now)?
There was a problem hiding this comment.
Never mind, I thought this header was public.
|
This is looking good in project-internal as well as external app testing on sim and device. |
incanus
force-pushed
the
remove-objc-linker-flag
branch
from
90066b9 to
423cfc1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce our binary size as well as obviate the need for the
-ObjClinker flag.