Allow annotation images to be updated

[RomainQuidet]

Add possibility to delete / update a sprite in order to update an AnnotationImage
#2210

Fixes #2517

[incanus]

Thanks for this @RomainQuidet. May take a bit, but we will try to review this soon. It looks pretty clean.

/cc @kkaefer @jfirebaugh @1ec5

[1ec5]

MGLMapView currently assumes that the reuse identifier is non-null. With a nil identifier, this line would crash. Is there a need for it to be nullable?

[RomainQuidet]

Hi,
That was a reminder to make it nullable as in the official MapKit. This identifier is used to recycle the instance for performance reason, it should not be used internally like today to reference the image view in a dictionary or even deeper with the sprites

[RomainQuidet]

@1ec5 : do you need me to update the pull request or will you merge it ?

[1ec5]

Since we use fast-forward merging, it'd be cleaner for you to rebase and resolve the conflicts. I'd be happy to do it but I'd have to open a new PR and close this one.

[RomainQuidet]

@1ec5 : branch rebased and corrections done according to your code review

[1ec5]

Merged in 9d0ab55...82a5575. The test failure above is a random KIF failure, and Bitrise won’t let me rebuild the fork branch.

Thanks @RomainQuidet!

[alexagat]

When I update the image property on a MGLAnnotationImage, for example in the didSelectAnnotation function:

func mapView(mapView: MGLMapView, didSelectAnnotation annotation: MGLAnnotation) {
    annotationsTitlesAndImages[annotation.title!!]!.image = UIImage(named: "map-pin-active")!
}

...I see the below block of code in mapbox-gl framework run, but the annotation image does not update:

- (void)setImage:(UIImage *)image {
    _image = image;
    [self.delegate annotationImageNeedsRedisplay:self];
}

Is this still an issue?

[1ec5]

@alexagat, can you open a new issue about this? It sounds like a regression if that’s the case.