This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Better zoom level–altitude conversion #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greatly simplified conversions between zoom level and altitude. Adjusted field of view to more closely match MapKit. Conversions are now well within the same order of magnitude as MapKit at all latitudes. Fixes #2266.
1ec5
force-pushed
the
1ec5-altitude-accuracy-2266
branch
from
6ea9bf6 to
b7223f2
Compare
| && _pitch == otherCamera.pitch && _heading == otherCamera.heading); | ||
| } | ||
|
|
||
| - (NSUInteger)hash |
There was a problem hiding this comment.
Thanks for adding isEqual:, will look at adding this to the a camera example.
There was a problem hiding this comment.
(Grr, commented on the wrong line there.)
On this line, I meant to ask: where do you see hash coming in useful?
There was a problem hiding this comment.
Any class that implements -isEqual: must also implement -hash, because equal objects must have the same hash value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly simplified conversions between zoom level and altitude. Adjusted the (apparently vertical) field of view to more closely match MapKit. Conversions are now nearly identical to MapKit at all latitudes.
The conversion code is now shared between iOS and OS X. It isn’t in mbgl, because although the conversions are more or less consistent with MapKit, it isn’t clear that they’re consistent with mbgl itself. (mbgl also has its own concept of “altitude” that’s distinct from the conventional meaning of altitude.)
Building off this improvement, MGLMapView now has a variation of
-flyToCamera:…that accepts a peak altitude parameter.Fixes #2266, and probably also fixes #3286. Also fixed #2456 along the way.
/cc @friedbunny @adam-mapbox