This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make osxapp document-based #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for multiple map windows open at a time.
Instead of forcing the system to restore windows between sessions (which confusingly switches the behavior of ⌘Q and ⌥⌘Q), honor the preference but have each new window inherit the style of the previous main window.
Even with the system preference set to close windows when quitting, the user would still expect this map-centric application to remember the last viewed map, because the world map isn’t quite as interesting.
The map feedback tool still uses mapbox.js, so its zoom levels are one off from Mapbox GL’s.
1ec5
force-pushed
the
1ec5-osx-document
branch
from
545f77c to
8aad739
Compare
|
I’m unable to get past the “random” failure in #3163, no matter how many times I retry (a dozen times today). Fortunately, this PR goes nowhere near the failing code. /cc @jfirebaugh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for multiple map windows open at a time. If windows aren’t kept when quitting, the last open window is restored at the next launch, just like in Maps.app.
Also fixed the zoom level used for the map feedback tool, and the URL handler now accepts a
pitchargument.