This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Reduce coupling of SourceInfo #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
3480-decouple-sourceinfo
branch
from
bb94fb6 to
4e1a96e
Compare
|
This pulls a lot of the preparatory code out of #2721. All commits in this PR can be reviewed on their own. |
Merged
kkaefer
force-pushed
the
3480-decouple-sourceinfo
branch
2 times, most recently
from
6916ba1 to
72db470
Compare
|
👍 on |
kkaefer
force-pushed
the
3480-decouple-sourceinfo
branch
3 times, most recently
from
966b53a to
b999760
Compare
|
@jfirebaugh I think I addressed all of your notes with this set of commits. Can you please give it a cursory look, in particular 389886e? I fixed based on your comments in |
|
Looks good! |
jfirebaugh
force-pushed
the
3480-decouple-sourceinfo
branch
from
b999760 to
e8705d5
Compare
This was referenced Jan 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SourceInfo object is too much integrated; it should become less dependent on other parts.