This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Send turnstile event when telemetry is paused #3495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The turnstile event is used solely to count monthly active users and should always be sent, regardless of whether the user has opted themselves out of telemetry.
The turnstile wasn't being turned if telemetry was paused, because
_session
is invalided andnil
'd inpauseMetricsCollection
. This change instantiates a temporaryNSURLSession
for the turnstile event.@1ec5 I could use your advice on my use of
strongSelf.session
here — before, we were straight-up calling_session
, but inside of a background async block.