This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Disable implicit animation of user dot bounds #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
This was referenced Jan 25, 2016
|
👍 in theory, but I'm still struggling to perceive much/any practical effect. |
Closed
1ec5
force-pushed
the
1ec5-user-dot-inaction-1125
branch
2 times, most recently
from
42f1c66
to
e6ebeee
Compare
1ec5
force-pushed
the
1ec5-user-dot-inaction-1125
branch
from
e6ebeee
to
29688e2
Compare
boundsj
added a commit
that referenced
this pull request
Apr 29, 2016
Like #3683, this change prevents Core Animation from implicitly animating changes to the annotation's bounds. This is done to reduce lag during map interactions like pan and drag.
boundsj
added a commit
that referenced
this pull request
May 6, 2016
Like #3683, this change prevents Core Animation from implicitly animating changes to the annotation's bounds. This is done to reduce lag during map interactions like pan and drag.
boundsj
added a commit
that referenced
this pull request
May 11, 2016
Like #3683, this change prevents Core Animation from implicitly animating changes to the annotation's bounds. This is done to reduce lag during map interactions like pan and drag.
|
For future reference, the behavior I disabled here is documented in “CALayer Animatable Properties” as a quarter-second basic animation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents Core Animation from implicitly animating changes to the user dot’s bounds. Therefore, the user dot no longer lags perceptibly when panning, zooming, or rotating the map.
We can similarly disable implicit animation of the accuracy circle’s size (#2045). However, that’ll have to happen in a different PR, because the accuracy circle’s animation is still useful for when the accuracy itself changes.
Fixes #2972 and gets us halfway towards #1125.
/cc @friedbunny @kkaefer