This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Min / Max Zoom Level Clamping In Core and Android #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Android. Clamping Min and Max zooms at Core GL for all platforms to use at runtime.
| zoom = 25.5; | ||
| } | ||
| if (minZoom < 0) { | ||
| zoom = 0.0; |
There was a problem hiding this comment.
This can be succinctly expressed as util::clamp(minZoom, 0.0, 25.5). But you should also ensure that the minimum zoom level is less than the maximum.
|
The numbers 0.0 and 25.5 should be factored out into constants. They can go right alongside |
|
Thanks for the suggestions @1ec5! I've now implemented and tested them locally in Android. Assuming Travis / Bitrise is happy with it I'll push it into |
|
Bitrise and Travis approved. Time to merge! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509