This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[node] add debug options to node bindings #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,15 @@ struct NodeMap::RenderOptions { | |||
| unsigned int width = 512; | |||
| unsigned int height = 512; | |||
| std::vector<std::string> classes; | |||
| bool debugTileBorders = false; | |||
There was a problem hiding this comment.
Why not use mbgl::MapDebugOptions here?
There was a problem hiding this comment.
To keep mbgl stuff out of NodeMap::ParseOptions. Should I switch it?
I replaced these three bools with the nested debug struct and forgot to remove them.
There was a problem hiding this comment.
Pulling in mbgl::MapDebugOptions here seems 👍 to me.
There was a problem hiding this comment.
switched to using mbgl::MapDebugOptions 1934258
ansis
force-pushed
the
node-debug-options
branch
2 times, most recently
from
539c108
to
1934258
Compare
| @@ -1 +1 @@ | |||
| Subproject commit 2aede5d8d1577101bf18405246220e7a710df607 | |||
| Subproject commit 717078fb6b0d02b944a12f4d40fc15567489d23b | |||
There was a problem hiding this comment.
Accidental submodule update?
There was a problem hiding this comment.
yeah, thanks for catching that
ansis
force-pushed
the
node-debug-options
branch
from
1934258
to
29d61c0
Compare
|
👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3579
👀 @jfirebaugh @mikemorris