-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[node] add debug options to node bindings #3840
Conversation
@@ -25,6 +25,15 @@ struct NodeMap::RenderOptions { | |||
unsigned int width = 512; | |||
unsigned int height = 512; | |||
std::vector<std::string> classes; | |||
bool debugTileBorders = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use mbgl::MapDebugOptions
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep mbgl
stuff out of NodeMap::ParseOptions
. Should I switch it?
I replaced these three bools with the nested debug struct and forgot to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling in mbgl::MapDebugOptions
here seems 👍 to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched to using mbgl::MapDebugOptions
1934258
539c108
to
1934258
Compare
@@ -1 +1 @@ | |||
Subproject commit 2aede5d8d1577101bf18405246220e7a710df607 | |||
Subproject commit 717078fb6b0d02b944a12f4d40fc15567489d23b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental submodule update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thanks for catching that
1934258
to
29d61c0
Compare
👍 |
fix #3579
👀 @jfirebaugh @mikemorris