Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use staging server in simulator #4726

Merged
merged 3 commits into from
Apr 19, 2016
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Apr 18, 2016

Use the staging telemetry server when compiled for the iOS Simulator. An alternative would’ve been to disable telemetry altogether in this scenario, but I think leaving it enabled and sending it to the staging endpoint leaves open the possibility of testing telemetry with mocked requests (#2822).

Disable telemetry when compiled for the iOS Simulator.

Fixes #3621.

/cc @boundsj @friedbunny @bleege

@1ec5 1ec5 self-assigned this Apr 18, 2016
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries tests labels Apr 18, 2016
@1ec5 1ec5 added this to the ios-v3.3.0 milestone Apr 18, 2016
@boundsj
Copy link
Contributor

boundsj commented Apr 18, 2016

👍 thanks. and also +1 to leaving it enabled but pointed to staging.

@friedbunny
Copy link
Contributor

👍

@bleege
Copy link
Contributor

bleege commented Apr 18, 2016

Yep, this makes sense. We do the same thing for the Android TestApp.

@1ec5 1ec5 force-pushed the 1ec5-staged-simulated-bogus-3621 branch from feeb675 to d9d77c6 Compare April 18, 2016 23:03
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 18, 2016

Per chat with @bsudekum, we’ve decided to remove references to the staging endpoint from the iOS SDK. Therefore, this PR now disables telemetry on the simulator. We’ll need to create an override mechanism when we’re ready to test telemetry.

1ec5 added 3 commits April 18, 2016 16:56
Use the staging telemetry server when compiled for the iOS Simulator.

Fixes #3621.
Also removed staging server URL from UI test application.
When running in the simulator, disable telemetry outright instead of pointing it to the staging server.
@1ec5 1ec5 force-pushed the 1ec5-staged-simulated-bogus-3621 branch from d9d77c6 to 7606fc6 Compare April 18, 2016 23:56
@1ec5 1ec5 merged commit 7606fc6 into master Apr 19, 2016
@1ec5 1ec5 deleted the 1ec5-staged-simulated-bogus-3621 branch April 19, 2016 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS telemetry Integration with Mapbox Telemetry libraries tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants