This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix hang observing user defaults on background queue #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a deadlock that could occur if the host application attempts to set user defaults on a background queue. Now we observer user defaults changes synchronously.
1ec5
added
iOS
|
👍 |
| @@ -249,6 +239,11 @@ - (NSString *)instanceID { | |||
| return _instanceID; | |||
| } | |||
|
|
|||
| - (void)userDefaultsDidChange:(NSNotification *)notification { | |||
| MGLAssertIsMainThread(); | |||
There was a problem hiding this comment.
Why the assert here? Could pauseOrResumeMetricsCollectionIfRequired not just be dispatched back onto main thread if needed instead?
There was a problem hiding this comment.
Good point. Fixed in 3c4049c.
|
Cherry-picked into 3.2.1 as b8ecbf6...78ddcd7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a deadlock that could occur if the host application attempts to set user defaults on a background queue. Now we observe user defaults changes synchronously.
/cc @jfirebaugh @boundsj