This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
use Clock::time_point::max() instead of frame time #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
force-pushed
the
max-timepoint
branch
from
881bab1
to
5d246ed
Compare
mikemorris
force-pushed
the
max-timepoint
branch
from
5d246ed
to
e208cac
Compare
|
LGTM 👍 |
For Style::cascade and Style::recalculate, when rendering with MapMode::Still. Fixes a subtle race condition with animated transitions exacerbated by cd1a06c.
mikemorris
force-pushed
the
max-timepoint
branch
from
e208cac
to
93b7d24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Style::cascadeandStyle::recalculate, when rendering withMapMode::Still. Fixes a subtle race condition with animated transitions exacerbated by cd1a06c./cc @brunoabinader @bsudekum @miccolis