This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Share shaders with gl-js #5122
Merged
Share shaders with gl-js #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you update INSTALL.md to explain how to get |
jfirebaugh
force-pushed
the
shared-shaders
branch
3 times, most recently
from
384ff58
to
0edfd6c
Compare
* git submodules are init'd automatically by the build script * styles are no longer bundled * Don't list libtool and automake: if mason fails to find a prebuilt binary, it's a bug and we want to fix it
jfirebaugh
force-pushed
the
shared-shaders
branch
from
e0ebf97
to
172e645
Compare
1ec5
added a commit
that referenced
this pull request
May 26, 2016
Documented the submodule step for running KIF-based SDK UI tests. This happened as part of installing core dependencies until #5122.
|
|
||
| git clone https://github.com/mapbox/mapbox-gl-native.git | ||
| cd mapbox-gl-native | ||
| git submodule init | ||
| git submodule update |
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mapbox/mapbox-gl-js#2599.
Note that this adds a build dependency on npm to all platforms. Previously, it was a build dependency for node, and a test dependency for node, osx, qt, and linux. If there's resistance to this, I can explore using a submodule instead. But I'd prefer to use npm.