This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[node] Don't fire callback when the AsyncRequest was canceled #5162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting a resource in the node bindings, we're currently returning a plain
AsyncRequest
object. This means that when we cancel the file request, we're not canceling the associated JSrequest()
call. We can't do that because it's immediate, but that immediate function call is async, so it could fire the passedcallback
function later on, at a point when theAsyncRequest
has long been destroyed.