Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] fixes #5406 view for annotation #5413

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Jun 20, 2016

No description provided.

@frederoni frederoni added iOS Mapbox Maps SDK for iOS ✓ ready for review annotations Annotations on iOS and macOS or markers on Android labels Jun 20, 2016
@@ -952,6 +952,15 @@ IB_DESIGNABLE
- (void)removeAnnotations:(NS_ARRAY_OF(id <MGLAnnotation>) *)annotations;

/**
Returns an MGLAnnotationView if the given annotation is currently associated
with a view, otherwise nil.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: put MGLAnnotationView in backticks so jazzy knows to linkify it. (Xcode renders the backticks, unfortunately, but I think the jazzy links are worth it.)

@1ec5
Copy link
Contributor

1ec5 commented Jun 20, 2016

👍

@frederoni frederoni force-pushed the 5406-view-for-annotation branch from 4c27c4c to 976e238 Compare June 20, 2016 16:15
@boundsj
Copy link
Contributor

boundsj commented Jun 21, 2016

As noted in #5406 should we use NS_SWIFT_NAME for this (and all future) APIs?

@1ec5
Copy link
Contributor

1ec5 commented Jun 21, 2016

That's covered by #5178, and it turns out that Swift 3 bridging elides the redundant words for us, no macros needed. Unless that changes in the next Xcode beta (unlikely), let's stick to the default bridging with no overrides for now.

@frederoni
Copy link
Contributor Author

frederoni commented Jun 21, 2016

  • Swift 2

screenshot 2016-06-20 16 43 55

- Swift 3

screenshot 2016-06-20 16 43 54

Default bridging looks good 👍

@frederoni frederoni merged commit 3995d6f into release-ios-v3.3.0 Jun 21, 2016
@frederoni frederoni deleted the 5406-view-for-annotation branch June 21, 2016 13:21
@wanggang316
Copy link

When release?

@boundsj
Copy link
Contributor

boundsj commented Jun 23, 2016

@wanggang316 This will be included in our next beta (beta 2) this week. There will be a release candidate after that and then a final release. You will find the current beta 1 release and the rest of planned releases once they are published in the releases page for this project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants