This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Always use symbol name for annotation update #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundsj
added
bug
iOS
| @@ -1771,13 +1771,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N | |||
|
|
|||
| MGLAnnotationContext &annotationContext = _annotationContextsByAnnotationTag.at(annotationTag); | |||
There was a problem hiding this comment.
annotationContext is unused, after these changes.
|
This works for me! No more |
This removes the guard that used to be in place from the time when
UIView backed annotations did not have invisible image placeholders.
Since images are now present for both sprite and UIView backed
annotations, the guard is no longer necessary and removing it allows
for the correct symbol name to be passed to the map object and this
gets rid of `[INFO] {Worker}[Sprite]: Can't find sprite named
'default_marker'` log message.
boundsj
force-pushed
the
boundsj-update-annotation-with-symbol
branch
from
aafab4c to
27deb3a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the guard for setting the sprite symbol name when annotation coordinates are updated. The guard was added when UIView backed annotations did not have invisible image placeholders. Since images are now present for both sprite and UIView backed annotations, the guard is no longer necessary and removing it allows for the correct symbol name to be passed to the mbgl map's
updateAnnoationmethod and this gets rid of[INFO] {Worker}[Sprite]: Can't find sprite named 'default_marker'log message.To put it another way, this gets rid of log messages related to unknown sprite names when annotations backed by UIViews have their coordinates changed.
This is an additional fix required for #5210 that was missed in #5461.
cc @friedbunny