This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] #5039 refactored MGLUserLocationAnnotationView #5573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transformation
…cationView with an ObjectAnimator.
…ebug exception catch. Fixes #5402
This merges v3.3.0 at beta 2 stage. Conflicts related to the os x -> macOS rename were corrected manually.
32 bit integers should be enough for zoom scale logic. In shape annotation logic, 'maxAmountOfTileFeatures' requires 64 bits because we are multiplying the zoom scale with the extent, which might give a number higher than std::numeric_limits<uint32_t>::max().
…ationChangeListener
Implements a custom std::streambuf to avoid creating temporary std::string objects and thus optimizing image decode. Suggested by @artemp in #5417 (comment).
- puts function definitions in a namespace ... {} rather than using namespace ...;
- remove trailing whitespace
- add trailing newline
- protect SQL statements from being formatted by clang-format
- Use glBindAttribLocation for GLSL attributes. - Create a separate shader for each shader that supports overdraw. Needed because each uniform location must be known for every program. - Create a separate VAO for each shader inside buckets. Needed because we can only bind a VAO to a specific shader. Fixes #5435.
`make foo` just builds `make run-foo` builds and runs
And implement this property in MGLFaux3DUserLocationAnnotationView. Generic reimplementation of #5816.
friedbunny
force-pushed
the
5039-MGLUserLocationAnnotationView-refactor
branch
from
b4d8298 to
e4a9173
Compare
|
I rebased this on master and then force-pushed. This PR targets the v3.3.0 release branch, so I’m closing it in favor of #5882. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5039 and #5037
MGLUserLocationAnnotationViewnow inherits fromMGLAnnotationView.MGLMapViewcalls-[MGLMapViewDelegate mapView:viewForAnnotation:]forMGLUserLocationto support a custom user dot. If the implementer still wants the default user dot, they should return nil in case annotation equalsmapView.userLocation