Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Wrapped world is blank #5648

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Wrapped world is blank #5648

merged 1 commit into from
Jul 12, 2016

Conversation

brunoabinader
Copy link
Member

When panning past the antimeridian, the wrapped copy of the world is blank until the antimeridian goes past the center of the view.

macos
ios

Reproduces in fe99295 on macOS and the iOS Simulator.

/cc @jfirebaugh

@1ec5 1ec5 added bug Core The cross-platform C++ core, aka mbgl labels Jul 12, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 12, 2016

Bisect implicates 1d46e83 (#5418).

/cc @brunoabinader

@brunoabinader
Copy link
Member

Nice catch @1ec5 - fixing it by reverting a line in 1d46e83 - tileScale indeed needs to be uint64_t not because of its input value, but because when adding it together in matrix::translate it overflows.

@brunoabinader brunoabinader merged commit e197540 into master Jul 12, 2016
@brunoabinader brunoabinader deleted the 5648-fix-matrix-when-panning branch July 12, 2016 09:04
@jfirebaugh
Copy link
Contributor

@brunoabinader
Copy link
Member

Can you please add a test case to https://github.com/mapbox/mapbox-gl-test-suite/tree/master/render-tests/regressions for this?

Will do 👍

brunoabinader added a commit to mapbox/mapbox-gl-test-suite that referenced this pull request Jul 13, 2016
brunoabinader added a commit to mapbox/mapbox-gl-test-suite that referenced this pull request Jul 13, 2016
@brunoabinader
Copy link
Member

Regression test added in mapbox/mapbox-gl-test-suite@1589dc7 and #5670.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants