Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Introduce a getDatabasePath() method that enables switching storage paths #5700

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

zugaldia
Copy link
Member

In order to enable this functionality, the developer can now set a SetStorageExternal boolean flag in the AndroidManifest.xml file to switch to external storage:

<meta-data
    android:name="com.mapbox.SetStorageExternal"
    android:value="true" />

The default value for storage remains internal storage (false), like until now.

Finally, note that this PR does not enable multiple sources for storage, tiles still need to be stored in the same database file on disk. The storage path, internal or external, is shared between the NativeMapView and the OfflineManager objects and, because it's a Manifest value, cannot be changed programmatically at runtime.

Fixes #5589.

/cc: @cammace @danswick @jfirebaugh @1ec5 @hjudge

@tobrun
Copy link
Member

tobrun commented Jul 15, 2016

LGTM :shipit:

@zugaldia zugaldia merged commit 5c037f4 into master Jul 15, 2016
@zugaldia
Copy link
Member Author

@tobrun Thanks for the 👀 . Merged.

@zugaldia zugaldia deleted the 5589-external-storage branch July 15, 2016 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants