This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[Qt] Use Qt text codec instead of nunicode #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmpsantos, thanks for your PR! By analyzing the annotation information on this pull request, we identified @artemp, @brunoabinader and @jfirebaugh to be potential reviewers |
|
👍 one less dependency! |
tmpsantos
force-pushed
the
tmpsantos-qt_utf8
branch
3 times, most recently
from
54c9ff6
to
2685838
Compare
tmpsantos
force-pushed
the
tmpsantos-qt_utf8
branch
from
2685838
to
730dd08
Compare
Remove one extra dependency. Qt has some bugs on the text codec it seems, but it is also important to keep the behavior aligned with the client API.
tmpsantos
force-pushed
the
tmpsantos-qt_utf8
branch
from
730dd08
to
65e2822
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove one extra dependency. Qt has some bugs on the text codec it seems, but it is also important to keep the behavior aligned with the client API.