Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix for stepwise functions #6328

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Fix for stepwise functions #6328

merged 1 commit into from
Sep 16, 2016

Conversation

clydebarrow
Copy link
Contributor

This change fixes the bugs reported in #6303 and #5823. It swaps the behaviour of the interpolate function for discrete values to return the value just less than the current zoom level, in accordance with the Mapbox style documentation.

@mention-bot
Copy link

@clydebarrow, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @yhahn and @ansis to be potential reviewers.

@1ec5 1ec5 added bug Core The cross-platform C++ core, aka mbgl labels Sep 14, 2016
@jfirebaugh
Copy link
Contributor

Ah, so this regressed in #4882. My bad.

Can you add a test here? Thanks for the PR!

@clydebarrow
Copy link
Contributor Author

Ok, test added and verified.

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed some whitespace and squashed it into a single commit. Will merge when CI passes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants