-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
@1ec5, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh and @tmpsantos to be potential reviewers. |
The Qt5 build bot is still failing on the Homebrew step:
|
@zugaldia Qt5 linking issue seems to be a known bug: Homebrew/legacy-homebrew#29938 (comment) Suggested approach is to manually add symlinks:
|
@brunoabinader you mind patching this up? CI seems to be broken for the whole project. |
The manual symlinks are already there: The permission issue seems to be fixed differently: Not sure if we have super user permissions on Bitrise, but will give it a try 👍 |
Adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI integration is passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding pkg-config, we should use packages that don't require pkg-config in the first place. See #6367
Bitrise’s Xcode 8 stack doesn’t have pkg-config installed, causing Mason to fail with:
This change installs pkg-config it via Homebrew. I didn’t add it to the iOS build bot’s configuration because the iOS targets don’t appear to need it.
/cc @jfirebaugh @brunoabinader