This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] MapChangeDidFinishLoadingStyle - Ensure style is loaded #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @tmpsantos, @jfirebaugh and @ansis to be potential reviewers. |
ivovandongen
force-pushed
the
fix-style-loaded-timing
branch
from
66b9802
to
1898bc4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reworking the fix in #6371 the
MapChangeDidFinishLoadingStylesignal is now sent a little too early. This results in style manipulations in the form of layer additions not showing up correctly as the layers/sources from the style itself are not added yet. This change fixes that.@tmpsantos Could you please review this change as you also looked at #6371?