[6749] fix annotation tap detection (smaller area for annotation imag…

[RomainQuidet]

I know tap detection is quite sensitive, my tests show it works well on different annotation images and views sizes, with offsets.

Fixes #6749.

[mention-bot]

@RomainQuidet, thanks for your PR! By analyzing the history of the files in this pull request, we identified @boundsj, @1ec5 and @rmnblm to be potential reviewers.

[1ec5]

@boundsj @incanus, can you review?

[1ec5]

Also, if you don’t mind, please make the corresponding changes in the macOS implementation of MGLMapView. Apart from annotation views (#5035), we’re trying to keep the annotation code consistent between the two platforms.

[RomainQuidet]

Ok I'll do it tomorrow for MacOS.

[RomainQuidet]

Fun to see that method (MGLAnnotationTag)annotationTagAtPoint:(NSPoint)point persistingResults:(BOOL)persist from MGLMapView.mm in macos target has already the correct queryRect size I patched in iOS, meaning the way I patched iOS is correct! As macos does not handle yet MGLAnnotationViews, there's no need to update macos code. The click detection works well on this platform.

[1ec5]

Ah, OK. I may be mistaken, but the reason may be that clicking on macOS is much more precise than tapping on iOS, so there was never a need to introduce a “slop area” around an annotation.

[margvl]

Hello, in our iOS application we are migrating from MKMapKit to Mapbox, however we are facing an issue, which may be related to this branch. Our annotations selection area is to big and user often selects a different annotations, we did not have this problem in MKMapKit.
Just wanted to know the status of this branch, because it was created in 2016.
Can I expect that it will be merged in near future?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.