This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - using bearing clockwise versus counterclockwise #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfirebaugh, @zugaldia and @ivovandongen to be potential reviewers. |
ivovandongen
suggested changes
Nov 7, 2016
| @@ -498,7 +498,7 @@ jdoubleArray nativeGetCameraValues(JNIEnv *env, jni::jobject* obj, jlong nativeM | |||
| jdouble buf[5]; | |||
| buf[0] = latLng.latitude; | |||
| buf[1] = latLng.longitude; | |||
| buf[2] = -(nativeMapView->getMap().getBearing()-360); | |||
ivovandongen
approved these changes
Nov 7, 2016
tobrun
added a commit
that referenced
this pull request
Nov 7, 2016
* [android] - using bearing clockwise versus counterclockwise * fixup brackets
tobrun
added a commit
that referenced
this pull request
Nov 9, 2016
* [android] - MyLocationView should facing above when location and compass bearing tracking are enabled. (#6829) * [android] - use current animated rotation value for calculating animated marker rotation difference (#6826) fix unit tests, input limiting is not handled by animateRotationBy instead of MarkerView. Changed test to validate if method was called with correct value. * [android] - only calculated offset margins for InfoWindow if View is found in current viewport, added example to the test app to test for regressions (#6877) * upgraded okhttp dependency to latest version (#6880) * Cancelable callback invocation (#6891) * [android] - allow onCancel to be invoked from camera cancel callbacks * set to null after finish * [android] - using bearing clockwise versus counterclockwise (#6917) * [android] - using bearing clockwise versus counterclockwise * fixup brackets * [android] - convert bearing values from core to Android SDK equivalent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6897.
Review @ivovandongen.