This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Don't initialize timestamps to TimePoint::min() #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flows In FrameHistory::needsAnimation, we are computing "time - previousTime", but since previousTime was initialized to Duration::min(), we got a integer overflow, which produced invalid values.
…down This is to test that continuous mode stops rerendering once no further changes are needed, i.e. to test the absence of "busy rendering".
|
@kkaefer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ansis, @jfirebaugh and @tmpsantos to be potential reviewers. |
|
Works great, both CPU monitor as tests confirm.
Thank you for picking this up! |
tobrun
approved these changes
Nov 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative fix to #6747/#6667: In
FrameHistory::needsAnimation, we are computingtime - previousTime, but sincepreviousTimewas initialized toTimePoint::min(), we got a integer overflow, which produced invalid values and made the map render continuously./cc @tobrun