This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Rename style spec properties #7310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
added
iOS
|
@frederoni, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @incanus to be potential reviewers. |
Documentation for attributes whose names we’ve overridden now mention the original style specification property name, with a link to the style specification documentation for the property.
1ec5
approved these changes
Dec 6, 2016
There was a problem hiding this comment.
This looks great. Now MGLLineStyleLayer.lineDashPattern is clearly related to MKOverlayPathRenderer.lineDashPattern for those switching from MapKit.
To aid cross-platform developers and those who author styles in Studio, I’ve added a blurb to each renamed property that mentions the original name according to the style specification, with a link to the style specification documentation for good measure.
|
9f9422d fixes a compiler error in iosapp caused by a reference to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6098
Renamed a couple of more style spec properties.