Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Tilt results in fling moving in a reverse direction #7383

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Dec 12, 2016

mitigates #5281, this PR impacts the fling gesture by

  • limiting the input for moveBy based on tilt current value (ranges from 1/2 -> 1/8)
  • lower limiting with no tilt, fling gesture shifts more
  • lower animation time, makes animation feel more natural and snappy (removes laggy ending)

@cammace can you test this out? feel free to play with the variables to get the best possible UX.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Dec 12, 2016
@tobrun tobrun added this to the android-v5.0.0 milestone Dec 12, 2016
@tobrun tobrun self-assigned this Dec 12, 2016
@tobrun tobrun requested a review from cammace December 12, 2016 13:52
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @zugaldia and @jfirebaugh to be potential reviewers.

Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good for now. Noting that we might want to revisit this later on though.

@tobrun tobrun merged commit b43aa9d into master Dec 13, 2016
@tobrun tobrun deleted the 5281-tilt-reverse-direction branch December 13, 2016 07:08
@tobrun tobrun modified the milestones: android-v4.2.1, android-v5.0.0 Dec 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants