Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Guides for style and GeoJSON authors #7542

Merged
merged 7 commits into from
Jan 5, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Dec 24, 2016

Added two guides to the jazzy documentation:

  • “Working with GeoJSON Data” maps GeoJSON concepts and types to the runtime styling API.
  • “Information for Style Authors” points out a number of tips for designing a style appropriate for an iOS or macOS application and also maps style JSON types to the runtime styling API to help Mapbox Studio users. This document is generated by make style-code-darwin just like the rest of the runtime styling API. I avoided talking in great detail about Studio or the runtime styling API to avoid overlapping with [ios] Adds guides to documentation sidebar #7488.

These two guides are shared between the iOS and macOS docsets. This means the iOS SDK documentation will include some language specific to macOS and vice versa. I think this is fine, given that Apple’s own guides do the same thing. The two guides are now separate but generated from the same template.

Fixes #7530.

/cc @friedbunny @ericrwolfe @mapbox/copycop

@1ec5 1ec5 added documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Dec 24, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Dec 24, 2016
@1ec5 1ec5 self-assigned this Dec 24, 2016
@1ec5 1ec5 requested a review from tmcw December 24, 2016 21:04
@mention-bot
Copy link

@1ec5, thanks for your PR! By analyzing this pull request, we identified @incanus, @boundsj and @friedbunny to be potential reviewers.

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 24, 2016

These guides highlight the need for autolinking in guides and the readme: realm/jazzy#715.

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 24, 2016

“Working with GeoJSON Data”

geojson

“Information for Style Authors” (iOS)

for-style-authors-ios

“Information for Style Authors” (macOS)

for-style-authors-macos

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 25, 2016

The “Information for Style Authors” guide now comes in two flavors, one for iOS and one for macOS. Both are compiled from the same template. I’ve updated the screenshots above to reflect the split.

@ericrwolfe ericrwolfe force-pushed the 1ec5-docs-concordance-7530 branch from 41190dc to 66aa67e Compare January 4, 2017 19:28
@ericrwolfe
Copy link
Contributor

Rebased atop the current release branch including #7488.

@ericrwolfe ericrwolfe self-requested a review January 4, 2017 19:29
Copy link
Contributor

@ericrwolfe ericrwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both useful in bridging the gap in understanding between the GeoJSON spec and the Mapbox Style spec 👍.

We ought to consider moving some of the content from For Style Authors.md out into the respective source documentation headers and link out from the guide, at least until auto linking in jazzy improves.

@1ec5 1ec5 mentioned this pull request Jan 4, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 5, 2017

We ought to consider moving some of the content from For Style Authors.md out into the respective source documentation headers and link out from the guide, at least until auto linking in jazzy improves.

realm/jazzy#715 is high on the 👊 list. We do mention most (if not all) of the information contained in the tables in the far-flung parts of the API reference, at least where there’s a difference. If you see anything that should be duplicated in the reference pages, please let me know.

In compiling these documents, I wanted to take into consideration @tmcw’s concern that someone familiar with Studio or GL JS would have no good starting point to apply their existing knowledge to the SDK or infer some of the more systematic differences in terminology or typing. The table of contents could be bewildering for these developers, despite your much-needed rework of it, especially when it comes to the source options.

@@ -16,6 +16,9 @@ framework_root: ../darwin/src
custom_categories:
- name: Guides
children:
- Adding Points to a Map
- Runtime Styling
- Working with Mapbox Studio
Copy link
Contributor Author

@1ec5 1ec5 Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These guides are located in platform/ios/docs/guides/, so they aren’t available to the macOS SDK. While most of the Runtime Styling and Working with Mapbox Studio guides apply equally to the macOS SDK, some of the screenshots would need to be substituted with macOS screenshots, and the “Adding Points to a Map” guide discusses view-backed annotations, which have yet to be implemented on macOS: #5035.

Let’s leave these guides out for now. We can figure out how to bring them over to the macOS SDK in a separate PR. Maybe we should think at that point about whether any of this great content could be reused in Android SDK documentation as well.

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 5, 2017

I edited the filter-to-predicate-format table to show how multiple values are handled in the format string (especially none to NOT (… OR …)):

predicates

@1ec5 1ec5 force-pushed the 1ec5-docs-concordance-7530 branch from 85e1792 to 1b7dd68 Compare January 5, 2017 03:22
1ec5 and others added 7 commits January 4, 2017 21:39
Added a guide to orient JSON stylesheet authors and Mapbox Studio users around the runtime styling API. An introductory section details the many considerations for designing a robust style for use with iOS and macOS devices.
Information for Style Authors is now two separate guides, one for iOS and one for macOS. Both are compiled from the same template. Added language about rotation, tilting, and printing.
@1ec5 1ec5 force-pushed the 1ec5-docs-concordance-7530 branch from 1b7dd68 to 2382f19 Compare January 5, 2017 05:48
@1ec5 1ec5 merged commit 2382f19 into release-ios-v3.4.0 Jan 5, 2017
@1ec5 1ec5 deleted the 1ec5-docs-concordance-7530 branch January 5, 2017 06:15
@nitrag
Copy link
Contributor

nitrag commented Jan 12, 2017

@friedbunny The URL for beta 7 docs is broken. Thanks for the prerelease!
https://www.mapbox.com/ios-sdk/api/3.4.0-beta.7/

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 12, 2017

@friedbunny
Copy link
Contributor

It’s up now

Well, as soon as it finishes publishing — give it a minute or two. 😉

The delay came from the fact that we finished building late last night and the jazzy generation process is slightly more involved than usual, as we make improvements in the betas.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants