This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[android] - rounded zoom when zooming with zoom button controller #7630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tobrun-rounded-zoom-button-controller
branch
from
January 8, 2017 09:59
9b09d15
to
e6f0835
Compare
1ec5
approved these changes
Jan 8, 2017
Checkstyle is failing:
Update: fixed in b8e55c6. |
A similar fix is going into the iOS and macOS SDKs in #8027. |
Per #8027 (comment) this proposed change will be brought to 5.0 for consistency with iOS. |
cc: @Guardiola31337 for review. |
On board for adding this but preferably woud hold off merging this PR atm, GLSurfaceView in #8031 will require some rewriting and that would mean double work as this PR could use some finetuning. |
Looks great 👍 |
Since this PR is scheduled for Android SDK v5.0.0, it needs to be rebased and retargeted at the release-ios-v3.5.0-android-v5.0.0 branch. |
Continued in #8299. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the zoom button controller to zoom to rounded values.
eg. map with zoom 1.435 will zoom in to 2 and 3 instead of current 2.435 and 3.435.
This PR also cleans up some duplicate code in MapGestureDetector related to zoom button controller.
cc @LornTao @1ec5
Review @zugaldia