Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

macOS: reuse OpenGL context when switching screens #8004

Merged
merged 1 commit into from
Feb 14, 2017
Merged

macOS: reuse OpenGL context when switching screens #8004

merged 1 commit into from
Feb 14, 2017

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Feb 9, 2017

Fixes #6654

@mention-bot
Copy link

@kkaefer, thanks for your PR! By analyzing this pull request, we identified @1ec5 to be potential reviewers.

@kkaefer kkaefer requested a review from 1ec5 February 9, 2017 11:09
1ec5
1ec5 reviewed Feb 9, 2017
View reviewed changes
platform/macos/src/MGLOpenGLLayer.mm Outdated
@@ -4,6 +4,8 @@

@implementation MGLOpenGLLayer

NSOpenGLContext* context = nil;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a global. Did you mean to make it an ivar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. How do I do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@implementation MGLOpenGLLayer {
    NSOpenGLContext *_context; // automatically initialized to nil
}

@1ec5 1ec5 added crash macOS Mapbox Maps SDK for macOS labels Feb 9, 2017
@1ec5 1ec5 added this to the macos-v0.3.1 milestone Feb 9, 2017
@kkaefer kkaefer force-pushed the macos-sdk-crash-multiple-windows branch from 79ed31f to 60127e2 Compare February 9, 2017 11:30
1ec5
1ec5 approved these changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🎉 Would you do the honors and add a blurb to the changelog?

@kkaefer kkaefer force-pushed the macos-sdk-crash-multiple-windows branch from 60127e2 to 1c70173 Compare February 10, 2017 08:49
@kkaefer kkaefer force-pushed the macos-sdk-crash-multiple-windows branch from 1c70173 to 940f01e Compare February 13, 2017 14:30
@kkaefer kkaefer merged commit 43e8150 into master Feb 14, 2017
@kkaefer kkaefer deleted the macos-sdk-crash-multiple-windows branch February 14, 2017 13:34
@1ec5 1ec5 mentioned this pull request Feb 18, 2017
Merged
@1ec5 1ec5 removed this from the macos-v0.3.1 milestone Feb 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
crash macOS Mapbox Maps SDK for macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkaefer @mention-bot @1ec5