This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] - allow zooming/scaling to use AnimationOptions #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun, thanks for your PR! By analyzing this pull request, we identified @1ec5, @jfirebaugh and @zugaldia to be potential reviewers. |
1ec5
approved these changes
Feb 23, 2017
include/mbgl/map/map.hpp
Outdated
| void setZoom(double zoom, optional<EdgeInsets>, const Duration& = Duration::zero()); | ||
| void setZoom(double zoom, const AnimationOptions& = {}); | ||
| void setZoom(double zoom, optional<ScreenCoordinate>, const AnimationOptions& = {}); | ||
| void setZoom(double zoom, optional<EdgeInsets>, const AnimationOptions& = {}); | ||
| double getZoom() const; | ||
| void setLatLngZoom(const LatLng&, double zoom, const Duration& = Duration::zero()); | ||
| void setLatLngZoom(const LatLng&, double zoom, optional<EdgeInsets>, const Duration& = Duration::zero()); |
There was a problem hiding this comment.
How about changing these other zoom-related methods too, for consistency?
There was a problem hiding this comment.
great catch, let me add those as well
tobrun
force-pushed
the
tvn-animationoptions-zoom
branch
from
ded7d12 to
839ddeb
Compare
|
How about making this change universally in map.hpp? |
tobrun
force-pushed
the
tvn-animationoptions-zoom
branch
2 times, most recently
from
13478b6 to
b6aa887
Compare
|
Requested changes have been implemented (resulted in changing some GLFW code) and were rebased on @ivovandongen JNI refactor PR for #6533. Can I get another round of 👀? |
tobrun
force-pushed
the
tvn-animationoptions-zoom
branch
from
b6aa887 to
75a2d2b
Compare
jfirebaugh
approved these changes
Feb 28, 2017
src/mbgl/map/transform_state.cpp
Outdated
| @@ -1,4 +1,4 @@ | |||
| #include <mbgl/map/transform_state.hpp> | |||
| #include <mbgl/map/transform_state.hpp> | |||
There was a problem hiding this comment.
Accidental added whitespace.
[glfw] - allow glfw binding to use AnimationOptions instead of using direction directly
tobrun
force-pushed
the
tvn-animationoptions-zoom
branch
from
75a2d2b to
471c80c
Compare
|
nit was fixed, merging. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to use AnimationOptions when performing a zoom/scale transformation (equivalent to #8092 for moveBy). This allows bindings to use an interpolator while doing a zoom/scale transformation.
To showcase the possibilities with this API, here is an example of the double tap zoom gesture using the
easeInOutBackinterpolator with an increased duration:Note that atm I'm not changing the default behaviour for Android.