Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[node] Fix module_name, check if release #8406

Merged
merged 1 commit into from
Mar 14, 2017
Merged

[node] Fix module_name, check if release #8406

merged 1 commit into from
Mar 14, 2017

Conversation

bsudekum
Copy link

@bsudekum bsudekum commented Mar 14, 2017

Since 6b0ad89 changed the module name, pre gyp was looking for node bindings mapbox-gl-native instead of mapbox_gl_native.

Also checks whether the build is a release or not instead whether its a debug build.

@mention-bot
Copy link

@bsudekum, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh and @1ec5 to be potential reviewers.

@bsudekum bsudekum changed the title [node] Specify build type [node] Don't publish debug build Mar 14, 2017
@bsudekum bsudekum changed the title [node] Don't publish debug build [node] Fix module_name, check if release Mar 14, 2017
@bsudekum bsudekum added the Node.js node-mapbox-gl-native label Mar 14, 2017
@bsudekum bsudekum merged commit fb2674e into master Mar 14, 2017
@bsudekum bsudekum deleted the buildtype branch March 14, 2017 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Node.js node-mapbox-gl-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants