Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[node] Work around a link error on macOS release builds #8409

Merged
merged 2 commits into from
Mar 15, 2017

Conversation

jfirebaugh
Copy link
Contributor

Fixes:

module.js:434
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: dlopen(/Users/john/Development/mapbox-gl-native/lib/mapbox_gl_native.node, 1): Symbol not found: __ZNK4mbgl5style5Layer2isINS0_11CustomLayerEEEbv
  Referenced from: /Users/john/Development/mapbox-gl-native/lib/mapbox_gl_native.node
  Expected in: flat namespace
 in /Users/john/Development/mapbox-gl-native/lib/mapbox_gl_native.node
    at Error (native)
    at Object.Module._extensions..node (module.js:434:18)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/john/Development/mapbox-gl-native/platform/node/index.js:5:12)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)

I don't know why this occurs.

cc @bsudekum

@mention-bot
Copy link

@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @1ec5 and @ansis to be potential reviewers.

@1ec5 1ec5 changed the title [node] Work around a link error on macOS release builds [node] Work around a link error on macOS Node release builds Mar 15, 2017
@1ec5 1ec5 changed the title [node] Work around a link error on macOS Node release builds Work around a link error on macOS Node release builds Mar 15, 2017
@1ec5 1ec5 added build Node.js node-mapbox-gl-native labels Mar 15, 2017
@1ec5 1ec5 changed the title Work around a link error on macOS Node release builds [node] Work around a link error on macOS release builds Mar 15, 2017
Copy link

@bsudekum bsudekum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsudekum bsudekum merged commit 841da96 into master Mar 15, 2017
@bsudekum bsudekum deleted the node-macos-release-link-error branch March 15, 2017 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Node.js node-mapbox-gl-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants