This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Guard against over calling pause or resume #8465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to the file source pause and resume method are triggered by UIApplicationDidEnterBackgroundNotification and UIApplicationWillEnterForegroundNotification notifications. Testing has shown that those notifications may happen more than once on device. This adds a local guard to protect against unbalanced calls to pause and resume.
boundsj
added
crash
iOS
|
@boundsj, thanks for your PR! By analyzing this pull request, we identified @1ec5, @jfirebaugh and @friedbunny to be potential reviewers. |
1ec5
approved these changes
Mar 18, 2017
boundsj
removed
the
⚠️ DO NOT MERGE
This was referenced Mar 19, 2017
|
I filed https://openradar.appspot.com/31154381 as a dupe of https://openradar.appspot.com/14075101. In our case, the unexpected, multiple instances of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8464
Calls to the file source pause and resume method are triggered by UIApplicationDidEnterBackgroundNotification and UIApplicationWillEnterForegroundNotification notifications. Testing has shown that those notifications may happen more than once on device. This adds a local guard to protect against unbalanced calls to pause and resume.