This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update MGLMapView logo view #8771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
GL JS parity
ericrwolfe
reviewed
Apr 19, 2017
There was a problem hiding this comment.
@1ec5 where'd you get the logo assets here?
The logos and SVG @mgosline referenced in the original ticket have a more subtle translucent grey border and the pngs have slightly different dimensions.
mapbox@2x.png here is 161x41, whereas the png @mgosline rendered was 169x42. Lmk if you need me to update.
|
Ah, I had revived this PR from an old stash, but it looks like the assets were redone after I first incorporated them into the repository. I’ll redo this. |
|
I’ve updated the logos to reflect the current artwork:
|
boundsj
approved these changes
Apr 24, 2017
friedbunny
approved these changes
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logo view in the iOS and macOS implementations of MGLMapView to display a subtle version of the logo that Mapbox unveiled today.
Compared to the previous wordmark, the new logo and wordmark have darker, more opaque strokes but more translucent fill. As a result, the image stands out more than it used to, but it compensates by looking more like a wordmark. It also looks a lot like the labels in Mapbox Streets Satellite:
For iOS, the existing alignment rect inset has been removed, because the wordmark’s baseline can’t determine the whole image’s alignment when the circle is present. This will put the wordmark farther from the bottom edge of the map view than is customary on iOS, but the wordmark’s baseline aligns with that of the “i” in the ℹ️:
On the other hand, the macOS SDK places textual attribution directly beside the wordmark, so an alignment rect inset is still required in order to align the two controls’ baselines:
Currently on master
No inset
This PR
/ref #1265 #1328
/cc @friedbunny @ericrwolfe @mgosline