Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - run style instrumentation tests on CI #9353

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jun 23, 2017

We recently fixed the source of our flaky tests in #9198. Time to scale the amount of tests we run on CI. This PR enables testing the full com.mapbox.mapboxsdk.testapp.style package instead of 1 regression test. This will help detect regressions faster with recent core changes related to async rendering.

@tobrun tobrun added Android Mapbox Maps SDK for Android tests labels Jun 23, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jun 23, 2017
@tobrun tobrun self-assigned this Jun 23, 2017
@tobrun tobrun requested review from zugaldia and ivovandongen June 23, 2017 10:02
@tobrun
Copy link
Member Author

tobrun commented Jun 23, 2017

It seems #9198 hasn't been merged yet, will need to merge release branch to master first.

@tobrun
Copy link
Member Author

tobrun commented Jun 23, 2017

Another issue is that CircleCI times out if the test takes more than 10 minutes to execute

@tobrun tobrun added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jun 26, 2017
@tobrun tobrun force-pushed the tvn-run-style-test-on-ci branch 5 times, most recently from f06880d to 5e62f48 Compare July 11, 2017 14:00
@tobrun tobrun removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jul 11, 2017
@tobrun
Copy link
Member Author

tobrun commented Jul 11, 2017

Release branch has been merged to master, timeout configuration was added to CircleCI config.
This PR is ready for review.

@tobrun tobrun force-pushed the tvn-run-style-test-on-ci branch from 3074419 to 1391e69 Compare July 12, 2017 08:56
@tobrun tobrun merged commit d8cad63 into master Jul 12, 2017
@tobrun tobrun deleted the tvn-run-style-test-on-ci branch July 12, 2017 09:21
@tobrun
Copy link
Member Author

tobrun commented Jul 12, 2017

For reference, tests are executing in 14 minutes time (this includes config / waitForDevice / run / downloadResults).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants