This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Disable fading when rendering still images #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
force-pushed
the
942-disable-fade-if-still-mode
branch
from
57205c1
to
5ea7d95
Compare
brunoabinader
force-pushed
the
942-disable-fade-if-still-mode
branch
from
5ea7d95
to
9a97333
Compare
|
This looks 💯 now, thanks for hitting this @brunoabinader! |
|
To clarify this change: Labels which which fade while zooming should not fade while a static image is created. This is because if the label is in transition, it could potential never end it's transition and show up opaque as seen above. This PR removes fading completely to make sure no label is opaque due to fading at render time. Tested out this PR, tests looked great. @jfirebaugh good to merge this? |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the static image rendering API, we have to disable fading.