This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - add Map change & visibility test activities #9425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| private String resolveMapChange(int change) { | ||
| switch (change) { |
There was a problem hiding this comment.
What about using a map/dictionary instead of switch?
|
|
||
| @Override | ||
| public void run() { | ||
| if (mapView != null && viewParent != null) { |
There was a problem hiding this comment.
What about simplifying this chain of if else? Expressions are hard to read/follow.
tobrun
force-pushed
the
tvn-additional-test-activities
branch
from
22ba7cd
to
a04e3e3
Compare
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #9412, While that PR didn't make the cut, it contained 2 useful test activities.
Adding them as a separate PR.