This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Implement 'circle-pitch-alignment' property #9426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from GL JS PR mapbox/mapbox-gl-js#4871.
Fixes issue #9349.
This is my first time using the
generate-style-code
script. Everything that it spit out looks reasonable, but I'm not sure what extra steps I should take to test the Android/iOS code it generates. I'm not even sure what the auto-generated transition code does.The one concern I had was that it wanted to interpret anything ending in
-alignment
as anAlignmentType
, which allows anauto
value. We don't have anauto
value forcircle-pitch-alignment
, so maybe we should override that with a stricter type? On the other hand, if someone did useauto
, the effect would end up being to use the defaultviewport
value, so it wouldn't be a very surprising result./cc @jfirebaugh